use cross storage move when renaming the part file during webdav put #16159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed, fixes the Thanks! 👍 |
|
Also verified that no other test has been broken: ✅ Testing with encryption enabled still fails (but is unrelated to this change) |
20 tasks
|
Refer to this link for build results (access rights to CI server needed): |
|
Tested, verified and works 👍 |
MorrisJobke
added a commit
that referenced
this pull request
May 8, 2015
use cross storage move when renaming the part file during webdav put
| @@ -162,11 +164,11 @@ public function put($data) { | |||
| if ($needsPartFile) { | |||
| // rename to correct path | |||
| try { | |||
| $renameOkay = $storage->rename($internalPartPath, $internalPath); | |||
| $renameOkay = $storage->moveFromStorage($partStorage, $internalPartPath, $internalPath); | |||
mmattel
pushed a commit
to mmattel/core
that referenced
this pull request
May 22, 2015
…miove use cross storage move when renaming the part file during webdav put
16 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15786
cc @PVince81 @DeepDiver1975 @nickvergessen